Avatar Review Updates - Githubissues

DigitalRiver / react-atlas

Composable React components with CSS Modules.

http://digitalriver.github.io/react-atlas/

MIT License

38 stars 25 forks source link

Avatar Review Updates #997

Closed Darper closed 5 years ago

Darper commented 5 years ago

Make the following changes found during a code review of the Avatar component:

JavaScript

Line 14: Change defaultImage to fallbackImage
Line 18: Replace UNSAFE_componentWillReceiveProps with getDerivedStateFromProps
Line 40: Remove filteredProps and allow user to pass custom props if they want to.
Lines 47-61: Convert lines to a getAvatar() function to reduce complexity of render function.
Line 69: Add style={style}
Line 70: Use new this.getAvatar() and only return children or prop data, not both.

Documentation

Change "beats" to "takes precedence/priority"
"Image beats icon" example fix icon from "fa" to "fab"
List order of precedence in top descriptive paragraph
Call out that icons will not fail down to Title, but instead not appear