fix: Binance issue where Fees = null so null += Anything == null

DigitalRuby / ExchangeSharp

ExchangeSharp is a powerful, fast and easy to use .NET/C# API for interfacing with many crypto currency exchanges. REST and web sockets are supported.

https://www.digitalruby.com

MIT License

737 stars 374 forks source link

fix: Binance issue where Fees = null so null += Anything == null #812

Closed O-Mutt closed 10 months ago

O-Mutt commented 10 months ago

This resolves an issue where the binance API returns the correct fees but the way we are handling fees is with a nullable decimal causing the += of fees to be null

O-Mutt commented 10 months ago

I would hope we could get this released as a bug version as this is blocking my current production environment from being able to manage trades appropriately.

vslee commented 10 months ago

Thanks for submitting all of these PRs. I can prepare a new release in a few days. If you'd like to get any other PRs in before then, that'd be great. In the meantime, your code changes are now available in the prerelease build: https://dev.azure.com/DigitalRuby/DigitalRuby/_artifacts/feed/DigitalRuby