search

DigitalRuby / ExchangeSharp

ExchangeSharp is a powerful, fast and easy to use .NET/C# API for interfacing with many crypto currency exchanges. REST and web sockets are supported.
https://www.digitalruby.com
MIT License
741 stars 374 forks source link

Coinbase API V2/V3 Updates #818

Closed BobDeCuir closed 10 months ago

BobDeCuir commented 10 months ago

This API now uses Coinbase Advanced Trade V2/V3. If you are using legacy API keys from previous Coinbase versions they must be upgraded to Advanced Trade on the Coinbase site. These keys must be set before using the Coinbase API (sorry).

vslee commented 10 months ago

@O-Mutt would you like to give this PR a review?

BobDeCuir commented 10 months ago

@O-Mutt , @vslee

I've updated the source and applied Matt's suggestions (thanks again, Matt).

All calls were tested for parameters and return values, and I even ran all sockets overnight to test for leaks, etc. Everything works on my side, so I have to bow out of this side-project. Use this, don't use it, it's up to you, but as far as I can tell, this would be the first library to successfully incorporate the new Coinbase Advance Trade API. (and it wasn't easy).

I won't be updating the ExchangeSharpTest app, and this no longer compiles. You'll have to do that update, as well as the console app.

Cheers,

Bob

O-Mutt commented 9 months ago

Thank you for the excellent work @BobDeCuir. I will merge these changes now to allow @O-Mutt to test and base his own PRs on if needed. Once @O-Mutt is ready, I will push a new NuGet for wider testing.

I did some minor testing, aside from the fairly lacking logging setup in the class (there are literally no logs) I was able to use it to place successful orders. I'd be happy to push this out wider

vslee commented 9 months ago

Great, I will work on updating the CI and pushing a new release.