Feature/django settings

DigitalShoestringSolutions / InventoryManagement

Shoestring starter solution for a simple inventory management system

GNU General Public License v3.0

0 stars 1 forks source link

Feature/django settings #14

Closed tobyaharris closed 2 months ago

tobyaharris commented 4 months ago

Adopted the SECRET_KEY system from Scrap. Made a few django settings more production-ready.

tobyaharris commented 4 months ago

Current unintended side effect of this branch is the UI isn't rendered in full colour and layout. on development the webpage looks like

but on this branch it looks like and

Why? @anandarupmukherjee any ideas?

tobyaharris commented 2 months ago

I'm going to split this in two - the django secret key and settings.py vs the DOCKERFILE/docker-compose startup sequence. EDIT: Turns out you can't - the reason they were bundled is that build time (Dockerfile) doesn't have access to the .env, but start time (docker-compose) does. Dockerfile hence can't run any manage.py.

What does need to be split out are the other django settings eg DEBUG (#21 ) and ALLOWED_HOSTS (#20 )...

tobyaharris commented 2 months ago

This PR is having some history / base issues. The only outstanding change is DEBUG=False. This will be reconsidered later.