Add good count to totals

DigitalShoestringSolutions / ScrapMonitoring

GNU General Public License v3.0

0 stars 0 forks source link

Add good count to totals #4

Closed tobyaharris closed 3 months ago

tobyaharris commented 5 months ago

Done for Operation View after user request - would this be useful in the other dashboards? At least it would be consistent.

tobyaharris commented 5 months ago

Should a user wish to hide the Pass count from the totals view, they can do so very easily by clicking the eye to toggle visibility of a field.

tobyaharris commented 3 months ago

No further changes, I'm happy with this. Changelog:

Added "Pass" to total counts in top left of Operation, Part and Snapshot dashboards
Fixed colour backgrounds for Pass, Rework and Scrap counts in these dashboards, rather than changing with the value

tobyaharris commented 3 months ago

Thanks for the approval. As a general procedural question, do you think it best for the PR author to do the merge, the reviewer-approver, or another? Generalising our development model to include community contributions, it will be one of us doing the review and merging. I'm tempted to suggest have the reviewer complete the merge.