search

DigitalSlideArchive / HistomicsUI

A Girder plugin for pathology image annotations and analysis.
Apache License 2.0
57 stars 20 forks source link

Remove TCGA endpoints #123

Open manthey opened 2 years ago

manthey commented 2 years ago

There are some vestigial endpoints for importing data from the TCGA that haven't worked since the hosting service changed. The endpoints and models associated with this should be removed.

manthey commented 2 years ago

@dgutman Probably if you aren't using these endpoints and models, no one is and they safely be removed. I'd rather not maintain tests for things that we don't use -- they could always be broken out to another plugin if anyone else needs them.

dgutman commented 2 years ago

I use them in one instance of the dsa I still maintain for my main cdsa site.. we can talk next week ..

On Thu, Feb 17, 2022, 12:06 PM David Manthey @.***> wrote:

@dgutman https://github.com/dgutman Probably if you aren't using these endpoints and models, no one is and they safely be removed. I'd rather not maintain tests for things that we don't use -- they could always be broken out to another plugin if anyone else needs them.

— Reply to this email directly, view it on GitHub https://github.com/DigitalSlideArchive/HistomicsUI/issues/123#issuecomment-1043195291, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFODTWFLC4G4FXQNQDZVCLU3UTIPANCNFSM5OA6FS5Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>