search

DigitalSlideArchive / girder_volview

Other
2 stars 2 forks source link

Return VolView file manifest JSON from GET item/:id/volview #5

Closed PaulHax closed 7 months ago

PaulHax commented 1 year ago

Could modify GET item/:id/volview to return a JSON file with direct file/:id links to all files in the Item. If a session.volview.zip file is in the item, just return the latest session.volview.zip file.

Could then eliminate the item/:id/volview/datasets endpoint. Also, would get direct download of files from S3 bucket asset-stores, rather than having girder zip them all up, then passing to VolView. Downside: Some DICOM volumes have 500+ files, resulting in many HTTP requests.

PaulHax commented 1 year ago

@manthey Just FYI, currently this plugin zips up all the "dataset" files in the item and returns that to VolView via item/:id/volview/datasets

https://github.com/PaulHax/girder_volview/blob/beb9c426b1663287fd963264fc5d5db193da725a/girder_volview/__init__.py#L84-L95

So probably don't have issues with funky CORS configs on S3 buckets now. But would be nice to implement the above sometime and save some bandwidth.