DigitalSlideArchive / import-tracker

A Girder plugin for data import tracking in HistomicsUI
Other
2 stars 2 forks source link

Remove extraneous filtering for unique import edits in importList view #35

Closed willdunklin closed 5 months ago

willdunklin commented 5 months ago

Changed the mongo query for assetstore/{id}/imports {unique: true} endpoint to store the _id of the first element in unique grouping; which avoids the manual filter-based search I was previously doing to find _id. This _id is needed as a reference for re-import-editing unique imports as we need a reference to an individual import record to copy.

willdunklin commented 5 months ago

Addresses #34

manthey commented 5 months ago

This isn't sufficient. The code here: https://github.com/DigitalSlideArchive/import-tracker/blob/main/import_tracker/web_client/views/reImport.js#L20-L22 still checks if the import id is within the paged request of the last 50.

willdunklin commented 5 months ago

Thanks for the catch