Add support for generic assetstores

DigitalSlideArchive / import-tracker

A Girder plugin for data import tracking in HistomicsUI

Other

2 stars 2 forks source link

Add support for generic assetstores #38

Closed willdunklin closed 2 months ago

willdunklin commented 3 months ago

Change importDataWrapper() to allow for generic parameters, per https://github.com/girder/girder/pull/3527
Removes outdated DICOMweb-specific code
Adds support for Girder Assetstore re-import pages

manthey commented 2 months ago

In testing this with a girder_assetstor, I think that plugin needs some modifications to allow things to work as expected. See https://github.com/DigitalSlideArchive/girder_assetstore/pull/17. If you think that PR is correct, I think we can merge both that and this PR.

willdunklin commented 2 months ago

@manthey those compatability changes looked good, I merged them on the girder_assetstore side. I've opened another PR on that side for additional compatibility changes as well https://github.com/DigitalSlideArchive/girder_assetstore/pull/18

I don't have permission to merge this PR while it's not approved, would you mind approving/merging this one if everything looks good?