search

DigitalSlideArchive / wsi-superpixel-guided-labeling

Other
3 stars 5 forks source link

Do not cut off film strip items on small screen #108

Closed bnmajor closed 6 months ago

bnmajor commented 7 months ago

Wrap cards so that they are not cut off in small screens

resize_filmstrip

Fixes #104

manthey commented 7 months ago

Would it be better to change the number of chips based on width rather than stacking them up or making them sparse?

bnmajor commented 7 months ago

Would it be better to change the number of chips based on width rather than stacking them up or making them sparse?

Sure thing!

https://github.com/DigitalSlideArchive/wsi-superpixel-guided-labeling/assets/51238406/6c2232b9-9e52-45f2-af94-dc83c5e833a5

One thing to note with these changes is that we're displaying the number of cards that fit nicely on the screen, so for larger screens this may now be more than 8 (the previous hard-coded selection). You can see in the clip that I now see 10 cards by default. If we want to clamp this value we can, or we can allow it to remain dynamic to minimize wasted space.