DigitalSlideArchive / wsi-superpixel-guided-labeling

Other
3 stars 5 forks source link

Simplify inputs #113

Closed bnmajor closed 6 months ago

bnmajor commented 6 months ago

This further simplifies editing hotkeys and label names:

  1. Hotkeys can now be edited with a single click. Changes are automatically accepted without further prompts/clicks. Clicking away from the text will exit the edit mode.

simple_hotkey_edit

  1. Editing label names can now also be completed by clicking outside of the input.

accept_on_blur

Fixes #103

manthey commented 6 months ago

I'd recommend making this so it stops editing the hot key after a key is pressed (so you have to click it again to change it again).

Also, in my first run through, I somehow once again had the keyhandler doing too much, so when I set the hotkey it also labelled the current chip. Reloading the webpage resolved this (but I thought the guard in #106 would have prevented this).

manthey commented 6 months ago

When you click to edit a category, can we change the focus to the edit box and highlight the entire category. At least when it is New Category, I just want to replace it with completely new text, so it would save a few clicks.

bnmajor commented 6 months ago

I'd recommend making this so it stops editing the hot key after a key is pressed (so you have to click it again to change it again).

Sure thing! Updated :+1:

Also, in my first run through, I somehow once again had the keyhandler doing too much, so when I set the hotkey it also labelled the current chip. Reloading the webpage resolved this (but I thought the guard in #106 would have prevented this).

I was finally able to reproduce this consistently and I have a fix in that prevents the re-creation of the container (and consequent double registration of the event handler). This should no longer be an issue.

When you click to edit a category, can we change the focus to the edit box and highlight the entire category. At least when it is New Category, I just want to replace it with completely new text, so it would save a few clicks.

Done!