search

DigitalSlideArchive / wsi-superpixel-guided-labeling

Other
3 stars 5 forks source link

Superpixel speed improvements #116

Closed bnmajor closed 4 months ago

bnmajor commented 6 months ago

Currently works when concurrency is 1. Needs support for queuing in the case of larger concurrency values.

manthey commented 5 months ago

@bnmajor Can you merge or rebase this on master? I filed an issue (#123) related to it, and I'm seeing something else odd, but maybe updating to master will help.

bnmajor commented 5 months ago

@bnmajor Can you merge or rebase this on master? I filed an issue (#123) related to it, and I'm seeing something else odd, but maybe updating to master will help.

Rebased!

manthey commented 5 months ago

I have a case where I have two images and started finding superpixels. I created my label categories. When the first image finished, I labelled some pixels. I then clicked "Begin Training" while the second image's superpixels were still being calculated (and neither had their features extracted). I see a javascript error:

Internal Server Error {"message": "KeyError: KeyError('jobId')", "trace": ["<FrameSummary file /opt/girder/girder/api/rest.py, line 655 in endpointDecorator>", "<FrameSummary file /opt/girder/girder/api/rest.py, line 1247 in POST>", "<FrameSummary file /opt/girder/girder/api/rest.py, line 983 in handleRoute>", "<FrameSummary file /opt/girder/girder/api/rest.py, line 1302 in wrapped>", "<FrameSummary file /opt/girder/girder/api/access.py, line 56 in wrapped>", "<FrameSummary file /opt/slicer_cli_web/slicer_cli_web/rest_slicer_cli.py, line 545 in rerunHandler>"], "type": "internal", "uid": "d5b21caf-a6b2-495a-8ed5-883aa5bb8f9a"}

Reloading the page gets over this.

Also, if you reload the page before any superpixels are finished calculating, you see the initial options page for picking superpixel size, etc.

bnmajor commented 5 months ago

I have a case where I have two images and started finding superpixels. I created my label categories. When the first image finished, I labelled some pixels. I then clicked "Begin Training" while the second image's superpixels were still being calculated (and neither had their features extracted). I see a javascript error [...] Reloading the page gets over this.

Also, if you reload the page before any superpixels are finished calculating, you see the initial options page for picking superpixel size, etc.

I believe that both of these issues should be corrected now.