search

DigitalSlideArchive / wsi-superpixel-guided-labeling

Other
2 stars 5 forks source link

Read and write hotkeys to/from config file #83

Closed bnmajor closed 4 months ago

manthey commented 5 months ago

Seemingly unrelated to this PR (so it could be addressed in a different one), after I have edited the hot keys, all hot keys are ignored on the chips. If I reload, I get the saved hotkeys and they they work correctly.

bnmajor commented 4 months ago

Seemingly unrelated to this PR (so it could be addressed in a different one), after I have edited the hot keys, all hot keys are ignored on the chips. If I reload, I get the saved hotkeys and they they work correctly.

I don't seem to be able to reproduce this... To clarify: Once you've begun editing have you

  1. pressed the enter key to accept the change and
  2. clicked the check mark to accept all changes

I think that this may be the same as what @jagstein was seeing, but I'm not sure if this is because of a confusing UI or if I am just missing steps to reproduce the problem.

manthey commented 4 months ago

My reproducing steps:

Start a new project (I have two images, but I don't think that matters). Create your first set of categories and do one training. Without reloading anything (on chrome), when the chips first appear, it looks like the default hot keys get applied twice (that is, typing "1" applies category one to two chips (like the event is double bound). Edit the hot keys (e.g., change "1" to "b"). Now, typing "b" does nothing (nor do the other unchanged hotkeys). Reload and all is well. Edit the hot keys, and again the hotkeys do nothing until reload.

bnmajor commented 4 months ago

My reproducing steps:

Start a new project (I have two images, but I don't think that matters). Create your first set of categories and do one training. Without reloading anything (on chrome), when the chips first appear, it looks like the default hot keys get applied twice (that is, typing "1" applies category one to two chips (like the event is double bound). Edit the hot keys (e.g., change "1" to "b"). Now, typing "b" does nothing (nor do the other unchanged hotkeys). Reload and all is well. Edit the hot keys, and again the hotkeys do nothing until reload.

I made the mistake of trying to reproduce on an existing project. Starting from scratch I am seeing this behavior now, thank you!

bnmajor commented 4 months ago

I made the mistake of trying to reproduce on an existing project. Starting from scratch I am seeing this behavior now, thank you!

@manthey I am back to square one with this issue - after successfully reproducing once yesterday I have not been able to reproduce again. Since this bug does seem unrelated to this PR would you be alright with us merging these changes in so that I can rebase and finish testing #88? I will open a new issue & PR for the bug that you have described.