search

DigitalState / Portal

The DigitalState Portal Spa
MIT License
5 stars 2 forks source link

Add configurable icon for Services #44

Closed StephenOTT closed 7 years ago

StephenOTT commented 7 years ago

screen shot 2017-09-07 at 8 04 34 pm

see https://github.com/DigitalState/Services/issues/28 for dependency.

Lets store the icon information in data.icon

StephenOTT commented 7 years ago

Note: The field will be translatable

StephenOTT commented 7 years ago

added today as per @baddlan. But does not work. @baddlan was this tested? screen shot 2017-09-27 at 7 59 07 pm

admin: screen shot 2017-09-27 at 7 59 53 pm

Appears the data field is not returned? @mario-digitalstate can you confirm that Services list application/hal+json returns the data field ?

marioprudhomme commented 7 years ago

Will need to add it to individual/anonymous read permissions.

Also if you can use normal constant strings instead of actual FA class names, that would be better since we wouldn't be tied to FA. Example: "search" instead of "fa-search". In the ui, you can either switch-case or programmatically transform the string into a FA class name. It's a concern of the theme, not the backend.

P.s. we can use the FA class names (minus the FA part) for the constant strings to keep things simple.

baddlan commented 7 years ago

Actually, that's exactly how it works right now. I have fa- prepended to the class name so the icon field should only contain paint-brush for example.

StephenOTT commented 7 years ago

@baddlan has the comment from @mario-digitalstate been completed?

Will need to add it to individual/anonymous read permissions.