DigitalTransgenderArchive / homosaurus_site

The public display of the homosaurus vocabulary.
8 stars 3 forks source link

Update how the 040$f is set in the mapping to MARCXML #31

Closed gmcharlt closed 6 months ago

gmcharlt commented 11 months ago

I noticed that there is a discrepancy in the code assigned to the thesaurus by the Library of Congress ("homoit") versus the code that shows up on the 040$f of the MARCXML authority records generated by the website ("homosaurus").

Per the documentation of the 040 field by the Library of Congress, subfield $f may contain either the name of the thesaurus or the code. However, I know of at least two library software systems (Koha and Evergreen) that would expect the values in the authority 040$f and the bib 650$2 to match exactly, so I suggest considering updating the mapping to set the 040$f value to "homoit".

If you agree, I'm happy to toss a pull request your way.

kjrawson commented 10 months ago

@scande3 just wanted to check with you saw this comment?

scande3 commented 7 months ago

@gmcharlt -> Apologies for the slow reply on this issue as had missed it previously. Sure if you still want to submit that pull request. Thanks!

gmcharlt commented 7 months ago

@scande3 Thanks! I've opened #34

scande3 commented 6 months ago

@gmcharlt -> Thanks for the contribution! I've approved and merged it.