search

Digitalbrainstem / ejs-grammar

EJS Grammar for VSCode
MIT License
75 stars 28 forks source link

EJS Grammar 2.0 (language server based) #41

Open ExE-Boss opened 5 years ago

ExE-Boss commented 5 years ago

I dislike the changes from #38, plus it still doesn’t provide JavaScript code completion and code lens.

The only way to properly support that will be to implement a language server.

Betanu701 commented 5 years ago

While we may have our differences, #38 did bring some improved functionality, while admittedly breaking other functionality, I agree with you.

Having a proper language server is going to be key. We need to make sure that we include html and javascript as included languages so that their functionality remains with the added benefit of using EJS. I admit I have not looked into this in a while, so I am not sure what has been added in VSCODE to allow cross languages.

I know you already cloned master to DEV, but if you want to make version 2.0 off of the version before 1.0, I would be ok with that as 1.0 is entirely different. I know you did a lot of hard work for the version before, and I honestly thank you for that,