DigitaleGesellschaft / jekyll-theme-conference

Jekyll template for a conference website containing program, speaker, talks and room overview
MIT License
64 stars 59 forks source link

Speaker links ignored #10

Closed pazz closed 3 years ago

pazz commented 3 years ago

I have one more for you: When you generate the demo page using the data from the repository, the links attached to speakers in their yml files are ignored:

person-a.md

---
name: Tolga Philip
first_name: Tolga
last_name: Philip
links:
  - name: Profile
    href: https://github.com
---

yet the speaker page contains this

    <h5 class="mt-4 mb-1">More Information:</h5>

    <ul class="list-unstyled">

          <li class="mb-1 ml-2 pl-2 border-soft-primary">
            <a class="text-reset" href="XXX" title="Profile">
              Profile
            </a>
          </li>

    </ul>

where XXX is the value of the last (absolute) url listed under my page wide links

 navigation:
    links:
      - name: Program
        disabled: false
        relative_url: /program/
      - name: Talks
        disabled: true
        relative_url: /talks/
      - name: Speakers
        disabled: false
        relative_url: /speakers/
      - name: Previous Editions
        menu:
          - name: foo
            absolute_url: YYY
          - name: bar
            absolute_url: XXX
pazz commented 3 years ago

The fix is to use absolute_url instead of href in the link. The demo person-a.md is simply outdated.

lorenzschmid commented 3 years ago

Thanks!