Fix a bug where date preposition "on" became "true" on talk detail page

DigitaleGesellschaft / jekyll-theme-conference

Jekyll template for a conference website containing program, speaker, talks and room overview

MIT License

64 stars 59 forks source link

Fix a bug where date preposition "on" became "true" on talk detail page #20

Closed mkyt closed 2 years ago

mkyt commented 2 years ago

Thank you very much for creating the elegantly crafted template. In using this template, I stumbled upon a bug where date preposition "on" becomes 'true" on talk detail page when multi-day mode is enabled (as in the attached screenshot). As I investigated the issue, I found the culprit to be YAML's treatment of on as true (boolean literal), instead of string literal. This patch fixes the issue by quoting on in lang.yml.

mkyt commented 2 years ago

Oh, I missed "no" on Portuguese translation! Thank you for pointing out. Now, the fix is included.

lorenzschmid commented 2 years ago

Thanks a lot!