DigitaleGesellschaft / jekyll-theme-conference

Jekyll template for a conference website containing program, speaker, talks and room overview
MIT License
64 stars 59 forks source link

program: initial full hour is missing? #9

Open pazz opened 3 years ago

pazz commented 3 years ago

I am missing the inital full hour in the program, but not with the demo program from the repo.

This is using version 3.0.3 from the gem, as installed with bundle. Any ideas?

2021-01-28-170433_1381x1402_scrot

this is my program.yml.

days:
- abbr: Tue
  date: '2021-03-30'
  name: Tuesday
  rooms:
  - name: Tuesday
    talks:
      - name: Logic and Learning in Network Cascades
        time_start: '13:30'
        time_end: '14:00'
      - name: A non-trivial polynomial time algorithm for a 3D Stable Roommates problem
        time_start: '14:00'
        time_end: '14:30'
      - name: Relative Error Streaming Quantiles
        time_start: '14:30'
        time_end: '15:00'

I should say that the room is called "Tuesday" intentionally (I have no parallel sessions and want them all on one page). There is a markdown file for the room as in the docs. Also, I checked that the quotes around the date string are not problematic.

pazz commented 3 years ago

Aha! It seems that the first talk/entry needs to be on the hour in order for this to work as expected. Consider this a bug report :)

lorenzschmid commented 3 years ago

I think everything works as expected: The first time in the table is given by the earliest talk. Please feel free to make a PR with a new option (e.g. under conference > program > start_full_hour: true) allowing to set the starting time via _config.yml file.

pazz commented 3 years ago

Nice! Thanks! I don't think this was documented..

Quoting Lorenz Schmid (2021-02-01 16:46:24)

I think everything works as expected: The first time in the table is given by the earliest talk. Please feel free to make a PR with a new option (e.g. under conference > program > start_full_hour: true) allowing to set the starting time via _config.yml file.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.*

lorenzschmid commented 3 years ago

Nice! Thanks! I don't think this was documented..

It is not implemented yet, in my comment I propose that, if you want, you could implement something which is alike (PR = pull request).