search

Digitaler-Impfnachweis / covpass-android

The official CovPass(-Check) Android apps and SDK.
https://digitaler-impfnachweis-app.de
Apache License 2.0
185 stars 59 forks source link

CovPassCheck camera very slow on some phones #102

Closed treysis closed 11 months ago

treysis commented 3 years ago

Avoid duplicates

Technical details

Describe the bug

The app has very bad performance on some lesser equipped phones. Specificslly Ulefone S1. The default camera app on the phone works smoothly, but the scanner of the CovPassCheck-app has huge lag with only 1-2 frames per second. The Austrian GreenCheck app works smooth as well.

Steps to reproduce the issue

Try scanning certificates on smartphones with low-spec hardware.

Expected behaviour

Camera should work smoothly without stuttering/lagging.

Possible Fix

Additional context

The fork on f-droid (based on an older version of CovPassCheck) works flawless.

alexcimander commented 3 years ago

Thank you treysis for your feedback! Looks like there is still room for improvement when it comes to the scanning-behavior. Let's see what we can do here. We have some improvements ready for release 1.13 - maybe they will help out. However, we will investigate on that!

s09bQ5 commented 2 years ago

Just a guess, but maybe the app uses a much higher camera resolution since it was switched from ZXing to BoofCV?

treysis commented 2 years ago

@s09bQ5 That could very well be the case. The f-droid version doesn't yet use BoofCV. Maybe it's not the resolution, but the general performance of BoofCV? On the other hand, Switzerland's Covid Certificate Check doesn't seem to use BoofCV but just ZXing, and it's also slow (the Austrian GreenCheck app however works fine).

Maybe it's within the crypto package? I don't know how I could test it. Maybe try with the last version before BoofCV was introducted? Which one is it and where would I get it?

Seems like it was introduced in v1.11 with commit https://github.com/Digitaler-Impfnachweis/covpass-android/commit/22973752f0d651ea0e57b2cf2e0489e32903c186 . So I should get v1.10 for testing. Don't know if it could maybe also be related to camerax. CameraX is also used by the Swiss app.

elschman commented 2 years ago

even 1.13 from google playstore contains this bug ..

1.95.12 from fdroid works fine for me on Samsung s5 mini at lineageos Andoid 9

memartinb commented 2 years ago

Hm, interesting. Experiencing camera stutter/freeze on Galaxy S5 mini (G800F) with LineageOS 16 / Android 9, Corona Tracing App works fine. Tested today with v1.27.0. Possibly related to #114?

pucherd commented 2 years ago

Hello @treysis, @memartinb, are you still experiencing this issue in version 1.30.0? We did some minor improvements in this version.

treysis commented 2 years ago

@pucherd I don't have the device anymore so I cannot test.

memartinb commented 2 years ago

Yes, still a problem on v1.31.1, tested today (latest on F-Droid).

However, #20 has become a workaround, so the app is usable now nevertheless.

ingowerren commented 11 months ago

In 2021, the European Union introduced the digital COVID certificate as an EU-wide recognised proof of vaccination, recovery or negative testing for COVID-19. This regulation expired on 30 June 2023. On a transitional basis, the EU will continue to operate the technical systems to enable cross-border certificate checks until 31 December 2023. The transitional operation will end on that date. In Germany, the possibility of issuing digital COVID certificates such as vaccination and recovery certificates will therefore be discontinued on 31 December 2023. The CovPass app and the CovPassCheck app will therefore also be discontinued. The CovPass app will be switched to wallet mode, where the stored certificates will be retained.

What does this mean for you? All functionalities will continue to beavailable until 31 December 2023.

From 1 January 2024:

Support for the app will no longer be offered.