search

Digitaler-Impfnachweis / covpass-android

The official CovPass(-Check) Android apps and SDK.
https://digitaler-impfnachweis-app.de
Apache License 2.0
184 stars 59 forks source link

"Check the validity of your certificates" notification displayed twice #214

Closed MikeMcC399 closed 2 years ago

MikeMcC399 commented 2 years ago

Avoid duplicates

Technical details

Describe the bug

When a 1/2 vaccination certificate with technical expiry date less than 28 days in the future is scanned and the app is restarted, the notification "Check the validity of your certificates" is displayed and then repeated after the first notification is dismissed.

Steps to reproduce the issue

  1. Install CovPass
  2. Go through onboarding
  3. Scan a 1/2 vaccination certificate with technical expiry date less than 28 days in the future
  4. Text information is displayed
  5. Exit the app and use Android to Close all apps
  6. Restart the app
  7. Note pop-up:
    "Check the validity of your certificates
    If you can renew this certificate in the app, you will receive a notification. You can find more information about replacing expired certificates in our FAQs."
  8. Tap "OK"
  9. Note the previous pop-up repeats:
    "Check the validity of your certificates
    If you can renew this certificate in the app, you will receive a notification. You can find more information about replacing expired certificates in our FAQs."

Expected behaviour

The app should only display the notification "Check the validity of your certificates" once in the above scenario.

alexcimander commented 2 years ago

Hey everyone! Update: We are currently working on a HF 1.26.1 which will take care of:

1.) Wrong reason for Re-Issue mentioned (Android only) https://github.com/Digitaler-Impfnachweis/covpass-android/issues/211 https://github.com/Digitaler-Impfnachweis/covpass-android/issues/210

2.) Misleading Text for (about to be expired) DCCs in DCC-Details https://github.com/Digitaler-Impfnachweis/covpass-android/issues/212 https://github.com/Digitaler-Impfnachweis/covpass-ios/issues/194

3.) Misleading Text within renewal process https://github.com/Digitaler-Impfnachweis/covpass-ios/issues/192

4.) "there are news" but not "there is news" within notification https://github.com/Digitaler-Impfnachweis/covpass-android/issues/217

5.) In Investigation: "No renewal offered for 1/2 vaccination if it is the only vaccination

the bugs

6.) Notification about expiry is played out twice (Android only) https://github.com/Digitaler-Impfnachweis/covpass-android/issues/214

7.) Re-Open of the App required (Android only) is not stated by the info text https://github.com/Digitaler-Impfnachweis/covpass-android/issues/213

are currently in investigation - we will provide a fix asap but these two are not expected to be fixed within the HF.

Thank you all for the patience and supporting discussions! 🦸

MikeMcC399 commented 2 years ago

6.) Notification about expiry is played out twice (Android only)

pucherd commented 2 years ago

Hello @MikeMcC399, this bug will be fixed in release 1.28

MikeMcC399 commented 2 years ago

This issue is confirmed fixed in CovPass 1.28.0.