search

Digitaler-Impfnachweis / covpass-android

The official CovPass(-Check) Android apps and SDK.
https://digitaler-impfnachweis-app.de
Apache License 2.0
183 stars 59 forks source link

Enable screenshots (Follow up to #62) #216

Closed Ein-Tim closed 9 months ago

Ein-Tim commented 2 years ago

Avoid duplicates

Current Implementation

CovPass does not allow to take screenshots. Attempting to take a screenshot results in an error message from the OS.

Suggested Enhancement

Allow taking screenshots of CovPass.

Expected Benefits

Easier for debugging purposes and more. Also, the screenshot restriction can easily be bypassed, without root or anything, by saying "OK Google, take a screenshot". This screenshot protection does not add any security to the app, as there is literally a certificate export feature in the app. Why would you restrict a user to store a screenshot of the QR code of the certificate, but allow to export the whole certificate? You see, this makes no sense. If you have any points where the screenshot restriction actually adds security, please share them in this issue.

timokoenig commented 2 years ago

Agree that this doesn't make sense. This feature has never been implemented for iOS either

Matt-17 commented 2 years ago

What happened? This feature worked and it was great - even I did not need it for some months. Now it's gone when I need it again? As in #53 it was enabled wihtout any further explanation. Now it's disabled again - without any note? At least explain the reasons.

Ein-Tim commented 2 years ago

@Matt-17 I do not remember a time where CovPass allowed to take screenshots.

Matt-17 commented 2 years ago

@Ein-Tim I still have screenshots from October 2021 from this app. Maybe it was not for long, as I could use those for some time and did not recheck this feature once a month ;-) But I was pretty irritated today, when I could not take a new screenshot.

MikeMcC399 commented 2 years ago

The history of https://github.com/Digitaler-Impfnachweis/covpass-android/blob/main/common-app/src/main/java/de/rki/covpass/commonapp/BaseActivity.kt shows how screenshots have been disabled, enabled and disabled.

https://github.com/Digitaler-Impfnachweis/covpass-android/commit/2a8cf01f65cdbf9afa982b30fdff1f45a3a86ac3 was the last disable it seems.

Ein-Tim commented 1 year ago

Has anyone actually assessed this issue in the last year? cc @staeffy

ingowerren commented 9 months ago

In 2021, the European Union introduced the digital COVID certificate as an EU-wide recognised proof of vaccination, recovery or negative testing for COVID-19. This regulation expired on 30 June 2023. On a transitional basis, the EU will continue to operate the technical systems to enable cross-border certificate checks until 31 December 2023. The transitional operation will end on that date. In Germany, the possibility of issuing digital COVID certificates such as vaccination and recovery certificates will therefore be discontinued on 31 December 2023. The CovPass app and the CovPassCheck app will therefore also be discontinued. The CovPass app will be switched to wallet mode, where the stored certificates will be retained.

What does this mean for you? All functionalities will continue to beavailable until 31 December 2023.

From 1 January 2024:

Support for the app will no longer be offered.