Extra whitespace in EU printout

MikeMcC399 commented 2 years ago

Avoid duplicates

[X] Bug is not mentioned in the FAQ
[X] Bug is not already reported in another issue

Technical details

Device name: Samsung Galaxy A52 5G SM-A526B/DS
Android version: 12
App version: 1.27.0

Describe the bug

The EU printout contains extraneous whitespace:

between the introductory words of each paragraph and the following text
between the first part of a hyphenated word and the hyphen
before a full-stop at the end of a sentence

See screenshot: Certificate infos

Steps to reproduce the issue

In CovPass App

Tap "+" to scan a 1/2 vaccination certificate
Scroll down and tap on certificate
Scroll down and tap on "Create EU printout", tap "Next"
Tap Drive symbol
Tap Save

On Desktop

Open Drive https://drive.google.com/drive/my-drive
Open saved PDF with Adobe Acrobat DC
Note formatting gaps in information section

Expected behaviour

No extra white space should be shown.

Possible Fix

Review the certificate formatting.

MikeMcC399 commented 2 years ago

It seems like this issue may be caused if the certificate is not rendered at 100% of the DIN A4 210 x 297 mm template size from https://raw.githubusercontent.com/Digitaler-Impfnachweis/covpass-android/main/common-app-covpass/src/main/assets/VaccinationCertificateTemplate.svg.

MikeMcC399 commented 2 years ago

Also reported for Corona-Warn-App under https://github.com/corona-warn-app/cwa-app-android/issues/5356

Edit: The issue is fixed in CWA 2.26.

dsarkar commented 2 years ago

corresponding CWA issue tracked in Internal Tracking ID: EXPOSUREAPP-13635

MikeMcC399 commented 2 years ago

@dsarkar

This is a link to https://jira-ibs.wbs.net.sap/browse/EXPOSUREAPP-13635. Are you granting access to this link? If not, then probably it should be removed, since this is not an SAP-owned repository here.

MikeMcC399 commented 2 years ago

@pucherd

Has your team had a chance to look at this issue? If yes, is there any conclusion about whether the issue is in the CovPass Android app or in the template (or maybe both)?

MikeMcC399 commented 2 years ago

This issue has been fixed in the Corona-Warn-App version 2.26.

Are there plans to fix it in CovPass?

MikeMcC399 commented 2 years ago

This issue is no longer reproducible in CovPass Android 1.31.0.

Digitaler-Impfnachweis / covpass-android