Digitaler-Impfnachweis / covpass-android

The official CovPass(-Check) Android apps and SDK.
https://digitaler-impfnachweis-app.de
Apache License 2.0
184 stars 59 forks source link

The app is totally useless for providing the certificate to the "Digital Registration on Entry" #53

Closed rjungbeck closed 3 years ago

rjungbeck commented 3 years ago

The app actively prevents screenshots, so it does not allow the required upload of installed certificates.

This defeats the whole purpose of the the app: You need another (analog) prove of vaccination for entry.

MikeMcC399 commented 3 years ago

@rjungbeck You are referring to https://www.einreiseanmeldung.de/ I guess.

As a workaround you can use the Corona-Warn-App (CWA) which allows the storage of EU Digital COVID Certificates and allows screen shots.

In the early days of the CWA app, more than a year ago, screen shots were blocked for security reasons, however that restriction has been removed. Users worked around the blocked screen shots by taking photos of the screens, so blocking the screen shots didn't really increase security, it just made some things more difficult, also for reporting issues.

rjungbeck commented 3 years ago

I don't use CWA.

Giving CWA access to personal identifying information (ie name in vaccination certificate) destroys most of its already limited data protection.

The issue is with CovPass and has to be solved there.

The solution could either be very simple (allow screenshots) or more advanced (automatically use the certificate in the browser if the app is installed and has a certificate).

10Meisterbaelle commented 3 years ago

Solution: Don't allow screenshots, but there should be a button to save the QR Code

Matt-17 commented 3 years ago

As my duplicate is closed, I add my last comment here:

An export feature needs work while this solution (removing FLAG_SECURE) is almost free. What is the intention of setting the FLAG_SECURE?

Also it would be better for accessibility, isn't it?

10Meisterbaelle commented 3 years ago

What is the intention of setting the FLAG_SECURE

It might be because it prevents 3rd party apps from reading the QR Code from your screen

Ein-Tim commented 3 years ago

It might be because it prevents 3rd party apps from reading the QR Code from your screen

In this case it would make no sense that screenshots are enabled in the Corona-Warn-App and disabled in CovPass.

10Meisterbaelle commented 3 years ago

The Corona-Warn-App also had FLAG_SECURE before an update (I think)

Am Di., 10. Aug. 2021 um 12:16 Uhr schrieb Tim @.***>:

It might be because it prevents 3rd party apps from reading the QR Code from your screen

In this case it would make no sense that screenshots are enabled in the Corona-Warn-App and disabled in CovPass.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Digitaler-Impfnachweis/covpass-android/issues/53#issuecomment-895908057, or unsubscribe https://github.com/notifications/unsubscribe-auth/AK6KPAGCKJU65PAW4ULS2M3T4D4BLANCNFSM5A7EFSRA .

Matt-17 commented 3 years ago

It might be because it prevents 3rd party apps from reading the QR Code from your screen

Well, if I have to use CWA for this, you just put this problem to another app. If I take a photo of my QR Code for the mentioned reason, third party apps can even get the Code even from storage (and from my screen). I don't see an advantage while there are still downsides.

Ein-Tim commented 3 years ago

@10Meisterbaelle

Yes, at the very beginning, see: https://github.com/corona-warn-app/cwa-app-android/issues/516 & https://github.com/corona-warn-app/cwa-app-android/issues/987

Matt-17 commented 3 years ago

The Corona-Warn-App also had FLAG_SECURE before an update (I think)

Which actually is a reason to remove this flag here as well.

10Meisterbaelle commented 3 years ago

It might be because it prevents 3rd party apps from reading the QR Code from your screen

Well, if I have to use CWA for this, you just put this problem to another app. If I take a photo of my QR Code for the mentioned reason, third party apps can even get the Code even from storage (and from my screen). I don't see an advantage while there are still downsides.

I do see the downsides, but there are more advantages, but I prefer my suggestion:

Solution: Don't allow screenshots, but there should be a button to save the QR Code

Matt-17 commented 3 years ago

Please explain more specific, would could the downside of this? Also it would mean much more work than just allow it. If I need to use CWA, I can uninstall this app anyway.

10Meisterbaelle commented 3 years ago

Please explain more specific, would could the downside of this?

It would prevent 3rd party apps with permission to see your vaccination certificate, and it would also prevent accidentially showing the certificate while recording your screen, however, this is a minor benefit.

Ein-Tim commented 3 years ago

With version 1.7 you can now export certificates. They are exported as a PDF.

Matt-17 commented 3 years ago

That's confusing. When I click on export it's recommending not to send an e-Mail or share with other people and then I get the share dialog? How do I save it into my downlaods folder and why does it use the share dialog if it's not recommended to share?

But anyway, thanks for giving at least one possibility to export the QR Code somehow. Makes it much easier.

Matt-17 commented 2 years ago

Oh, finally this feature was implemented. Any explanation why you finally changed your mind?