Digitaler-Impfnachweis / covpass-ios

The official CovPass(-Check) iOS apps
https://digitaler-impfnachweis-app.de
Apache License 2.0
94 stars 18 forks source link

How is the federal state determined‽ #122

Closed Kamik423 closed 2 years ago

Kamik423 commented 2 years ago

I know it is not tracking my location. Is it using the IP address? Or just not making any assumption about a state and what it is trying to tell me is that it is gonna be inaccurate in most states? This message needs to be clarified!

6C7ABC74-D55E-4338-8855-DBFC3E928508

Ein-Tim commented 2 years ago

Which rule applies depends on the federal state you are in.

This only means that you should check whether 2G+ or 3G is the correct checking mode. There is no determination of the state.

Kamik423 commented 2 years ago

The way the note is formatted looks like it is specifically talking about 3G, not checks in general. Also some rules might not be closed by the state but instead an event organizer such as constraining something to 2G only, or necessarily requiring a test. This makes this message doubly confusing.

And does this also mean the app is incapable of checking for variant rules of the federal states?

Ein-Tim commented 2 years ago

The way the note is formatted looks like it is specifically talking about 3G, not checks in general.

Very true.

And does this also mean the app is incapable of checking for variant rules of the federal states?

Yes, there is no selection of different states or similar. The controlling person has to make sure that everything is correct for their federal state, in the very end.

Kamik423 commented 2 years ago

The controlling person has to make sure that everything is correct for their federal state, in the very end.

Well what is the point of using the app then in the first place?

Currently it missing booster checks and even when they are gonna be implemented they will be invalid for most states due to J&J.

Ein-Tim commented 2 years ago

Currently it missing booster checks and even when they are gonna be implemented they will be invalid for most states due to J&J.

What do you mean?

Kamik423 commented 2 years ago

Currently the app is going to be useless for confirming 2G+ (With booster replacing test). Most people are boostered now and multiple states have this rule.

Even if the app now implements booster checking but no rule variance for states it is still gonna be useless in all the states that vary from the national rule by requiring a 3rd vaccination with J&J.

timokoenig commented 2 years ago

@Kamik423 the J&J problem can be fixed without an app update. The rules on the national backend just need to be updated

Kamik423 commented 2 years ago

To my understanding every state has different rules for how valid J&J first booster is (2/1). Will the App every be able to account for variations like this? How does it detect the state? And what does the national backend have to do with it?

https://www.merkur.de/welt/johnson-booster-impfung-corona-regeln-bayern-nrw-bawue-sachsen-berlin-news-zr-91242821.html

Dale81 commented 2 years ago

@Kamik423 guess the state-based rules will not be reflected as they are so complex. Also the app would need a selection for the Bundesland to know, which rules to use. Possible even without an app update as also @timokoenig said, but all the rules need to be implemented and permanently updated...

But currently even the J&J one-dose vaccination is still not used during validation of the certificate even this is possible. If you scan such a certificate, the app still says, it is valid for 2G. So this needs to be fixed very urgent to have a fully usable app again as currently NO (really NO - correct me if I am wrong) 3G/2G/2G+ validation can be trusted by using this app because the certificate could always be J&J one-dose. That's why we do not use this app currently and from my perspective, no one should in Germany if you really want to make sure, that you check certificates based on the PEI rules for beeing "fully vaccinated".

Kamik423 commented 2 years ago

CC43FE22-1DFA-4ABD-87C3-87FF3CA8EA35

Mai this is the latest updated. Does this mean it is automatically determining the state or does it tell me to apply rules manually?

timokoenig commented 2 years ago

The app only differentiates between country and domestic. The app expects all states to have the same rules

Kamik423 commented 2 years ago

Why is the sentence

Which rule applies depends on the federal state you are in.

Even there then? What is it trying to say if all states are the same?

timokoenig commented 2 years ago

I guess only the team can answer that question. I would've expected something different as well

Dale81 commented 2 years ago

And can someone explain what the difference is between country and domestic? I mean... the app's intended use is for within germany, right? so why can I select another country?

Ein-Tim commented 2 years ago

@Dale81 In CovPass you can select other countries to check whether you are eligible for traveling into this country. In CovPassCheck you can select whether the rules inside of Germany (domestic) or for entering Germany (country) should be used.

Ein-Tim commented 2 years ago

Can this issue be closed?