search

Digitalist-Open-Cloud / Matomo-Plugin-ExtraTools

ExtraTools is a plugin for Matomo, which provides some console commands.
https://digitalist.cloud/
GNU General Public License v3.0
26 stars 12 forks source link

Add --port argument to the extratools plugin #29

Closed trobiyo closed 2 years ago

trobiyo commented 2 years ago

The --db-port argument is not available when using commands like matomo:install or database:create/delete, preventing to connect any external database in order to bootstrap an installation of the Matomo application.

I believe this can be a good improvement, specially for those databases offered externally, and not just focus on on those deployed internally or defaulting to the 3306 port.

mikkeschiren commented 2 years ago

Hi, @trobiyo Looking good, will take some time in the coming week to test this out, thanks for your contribution!

mikkeschiren commented 2 years ago

Looked good, but added a default port in:

    public function dbPort()
    {
        $port = '3306';
mikkeschiren commented 2 years ago

All merged, so thank you for your contribution @trobiyo !