Digitalist-Open-Cloud / Matomo-Plugin-TrackerDomain

Matomo plugin to set tracker domain
https://digitalist.cloud/
1 stars 2 forks source link

Notice - Undefined index: url #1

Closed Findus23 closed 2 years ago

Findus23 commented 2 years ago

Hi,

Someone on the forum reported this issue with the plugin:

WARNING: /plugins/TrackerDomain/TrackerDomain.php(106): Notice - Undefined index: url

https://forum.matomo.org/t/warnung-meldung-nach-4-9-0-update/45717?u=lukas

I'm not too familiar with PHP, but I think you can't split the isset() check like this if you are not sure that the index exists: https://github.com/digitalist-se/TrackerDomain/blob/af25dedafeb742a2358e148ad9254d093b47e9fb/TrackerDomain.php#L106-L107

Chardonneaur commented 2 years ago

I am confirming that we are still seeing this error message within the admin panel of Matomo.

mikkeschiren commented 2 years ago

Yeah, that was a bit lazy for me to miss this. I will fix this.

mikkeschiren commented 2 years ago

A fix for this has been pushed to a new release - 0.2.4.