Towards fixing windows compatibility issues

[alexpArtos]

• replaced path concatenation with "path.join", as this works in all platforms.
• added logic to detect the current platform, and run npm or npm.cmd as appropriate. This is needed to properly install gatsby in init.js, and run its build command in publish.js.
• added logic to expand a final wildcard * into a list of all the files under that path. In my tests, passing a specific contract only generated the documentation for the contracts "pulled" by that one.
• in init.js, changed the name of the downloaded gatsby tar.gz file to not have any whitespaces, because these were causing problems to me
• added a doxity.cmd file that sets the PWD environment variable, so that doxity can find it when looking for process.env.PWD.
• changed the compile target in package.json to commands that work on Windows (exclusively). It would be better to have a solution that worked in all platforms.

[alexpArtos]

This refers to issue #14. You can follow the discussion there.

[alexpArtos]

Thanks for approving the request, Ricardo. What is the process now, are more reviews required before the pull request can be merged?

Cheers, Alex

On Fri, 3 Aug 2018 at 09:16, Ricardo Banate notifications@github.com wrote:

@rbanate approved this pull request.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/DigixGlobal/doxity/pull/30#pullrequestreview-143091296, or mute the thread https://github.com/notifications/unsubscribe-auth/AmGQzQY1G7i6klQfQxpkX4esYnjVu70vks5uNAbVgaJpZM4VfrqO .

[alexpArtos]

Hi, any hint about when/if this can be merged? Thanks.

[alexpArtos]

Hi guys,

it's been several months since this was reviewed and approved. It's even longer for yudilevi's PR#17. Are there any plans to merge either of these to master?

Thanks.