search

DigixGlobal / governance-ui-components

Governance UI reusable components library
Other
3 stars 2 forks source link

In component proposal-card change ViewCta from <button> to <a> #355

Open crypto-supporter opened 5 years ago

crypto-supporter commented 5 years ago

https://github.com/DigixGlobal/governance-ui-components/blob/a7b0559a48e0a74ed953cc319a667ae850980508/src/components/proposal-card/style.js#L161

For better UX and SEO links should always be an tag. If we change the "VIEW PROJECT" button to an a -tag this will improve:

UX:

  1. it will be possible to open proposals in a new tab by holding down cmd + clicking.
  2. the browser will show where an a-tag will take them in the lower left of the window .
  3. Better Accessibility for handicapped people using screen readers and such

SEO

The crawlers will crawl the site better if links are a-tags instead of button-tags.