[FIX] - Improve claim transaction condition - Githubissues

DigixGlobal / governance-ui-components

Governance UI reusable components library

Other

3 stars 2 forks source link

[FIX] - Improve claim transaction condition #372

Closed rbanate closed 5 years ago

rbanate commented 5 years ago

Description

Update the condition for checking if there is a pending claim for a Proposal

Test Plan

Claim a Transaction with a very low gas
Confirm that transaction has failed
Confirm that you can claim the result and the step should be the same as the one that previously failed

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[ ] I have squashed my commit with a meaningful message before merging.
[ ] I have updated the documentation if needed and accordingly.
[x] I have added a test plan to my commit message for QA to follow.
[x] QA has tested and verified the PR.
[ ] I have signed and submitted the Contributors License Agreement.

mikej-digix commented 5 years ago

iteration: 1 status: PASSED environment: local

test condition:

if claim_voting status is "pending" THEN disable claim approval/voting result button
if claim_voting status is "confirmed/failed" THEN enable claim aproval/voting result button