search

DigvijaysinhGohil / Godot-Shader-Lib

Visual shader node library for Godot engine.
MIT License
136 stars 7 forks source link

Updating to the new version breaks the project #12

Open rontarum opened 2 days ago

rontarum commented 2 days ago

Hello, awesome addon, which has saved me from tons of shader code more than once. Today I saw the new version and decided to update, but I did it unwisely ... I just replaced the files of the old version of the addon with new ones. Of course, everything broke, thousands of errors, a running red line. Okay, I think I'll find the old version in the branches on github and return everything back. Apparently, the metadata was deleted somewhere (I don't understand this and cpp either), because now Godot makes no difference to the versions of the addon that I'm trying to select. All the nodes flew off, instead of them there are now disconnected "Unnamed". The very thought that I will have to re-select and configure node combinations in a bunch of shaders drives me crazy. I hope you have a solution to this problem, and forgive me for my recklessness. For more understand, console spams with yellow errs like this:

scene/resources/visual_shader.cpp:415 - Unnamed is missing a category. scene/resources/visual_shader.cpp:415 - Unnamed is missing a category.

DigvijaysinhGohil commented 2 days ago

Seems like I completely ignored the concept of compatibility while refactoring the code, I did change the structure so that it would be easier to build upon, without giving a thought that it would break existing shaders of the users. I am sorry for breaking your project, if you have a backup, I recommend revert back to that.

If you don't have a backup, try to download the earlier version. Just hit the code button and download as zip, see how it goes.

rontarum commented 2 days ago

Thanks for answer! Nope, still didn't work properly. Inside the code of my visual shader my_shader.tres there were apparently links to scripts of custom nodes from the addon, and after the breakdown Godot "kindly" cleaned them up and replaced them with sub_resource and unnamed nodes. So I'll just restore Win by restore point and so on. Hope you'll find this issue helpful to see and fix all imperfections in future :)