Add info button

[flywire]

In development

Reply to: https://github.com/Dijji/XstReader/issues/18#issuecomment-563249377

Objective was to put an icon to the left of the open button. Thinking Visual Studio Image Library 2017 or maybe but bold text works. Initial thought was a form, then inspired by app minimalist approach changed to a MsgBox. Issues:

• Still not clear how to get the version variable which must come from compiler
• Open is first button and haven't found where order is assigned
• Possibly drop icon on button or maybe it should be a tool button
• Wondering if whole status bar should be a toolbar at top of window, agree it's secondary content

Hmm ... A full-blown settings form is a different scope

[Dijji]

I like the little button, but not particularly where it is. The problem with the way you show it is that it is right in the middle of the status text box. I already have to hide the search text box while email export is in progress, and the button where you have it would interfere with almost every status display.

Maybe better would be in the very bottom right. If we do add settings at some point, it should probably be another small button with a gear wheel next to it. By which time it is all looking more like a header bar than a footer bar. But status display says it should be a footer, and I do not want to give up room for both.

I could tell you how to deal with the technical questions, but I will instead tell you what I do. Google is the developers friend. For instance, for the version I would search on "C# assembly version", or for the tab order "WPF tab order". Heaven knows what we used to do.

Dijji

[flywire]

I had thought about bottom right too and agree it is a better location.

No worries, I learnt python earlier this year developing an app with Google. It was the fresh search terms I was after. Before Google was computer magazines and newsletters.

BTW I'm the sort of person that likes clicking all the buttons and seeing what they do. I didn't Google Tab order, I just looked at the changes to the code and adjusted it. Lucky I don't go near the nuclear weapon control room. ;)

[Dijji]

Okay, now we are down to the detail:

• the handler for your button needs a descriptive name, e.g. btnOpen_Click and be located in the file near other click handlers
• you should not be turning on the print headers switch, it is nothing to do with this change
• you should be using StringBuilder to assemble your message text.
• Time to put the actual version in!

[Dijji]

This approach to opening the website for the repository will really not do. It is not something to do without positive user input, and it is not clear that clicking Yes will have that result. Better would be something more in line with typical expectation, like a clickable link. But if you want that, you would have to go to a pop-up panel. This should not be attempted in a box.

I will settle for a MessageBox if you remove opening the repository, and fix StringBuilder (stylistic, but building a string with + for so many terms is not pro-standard coding) and the version (the reason for the whole thing)

[Dijji]

Looking good. The only problem I have is that Application.ProductVersion does not exist, so this does not compile. Did you extend the App class and not check it in? Anyway, the following works: Version version = System.Reflection.Assembly.GetExecutingAssembly().GetName().Version;

[Dijji]

Yay! Thank you.