Dilbert66 / esphome-vistaECP

This is an implementation of an ESPHOME custom component and ESP Library to interface directly to a Safewatch/Honeywell/Ademco Vista 15/20 alarm system using the ECP interface and very inexpensive ESP8266/ESP32 modules .
GNU Lesser General Public License v2.1
129 stars 21 forks source link

Rf decoding #18

Closed nitej closed 3 years ago

nitej commented 3 years ago

Adds some support for decoding "raw" RF sensor messages sent from the RF transceiver to the main panel. Specifically, it picks out the "0x9E" messages that contain data from a sending sensor. These only contain the sensor serial and a byte that contains data from the sensor. These are pushed to new mqtt topics in the ademcoECP.ino example. This allows the user access to sensors not setup as specific zones (since that it configured in the main panel) and to potentially set zone information in more scenarios.

Dilbert66 commented 3 years ago

Looks great! Tks also for fixing up a couple things too. I'll apply these changes to the esphome branch as well. Tks again. I don't see anything that would cause issues so I'll merge them

Dilbert66 commented 3 years ago

Found an issue with where you put your else command for capturing the 0x9e. You have your else after the check for the 0xf7 subcommand under the 0x98 logic.

I've unmerged the changes for now. If you can correct and resubmit. That would be great.

Dilbert66 commented 3 years ago

I see the problem is I need to fix up the indentation on that section. It's horrendous so it's easy to get mixed up on the wrong looop. I'll fix it now.

Dilbert66 commented 3 years ago

Ok, i've cleaned up that section a bit