DiligentGraphics / DiligentTools

Utilities built on top of core module
Apache License 2.0
116 stars 71 forks source link

Make renderer "protected" (not private) in ImGuiImplDiligent class #157

Closed hamyyy closed 2 years ago

hamyyy commented 2 years ago

As the title suggests, it would be helpful to make the m_pRenderer member variable accessible to derived classes.

I'm currently working on an ImGui docking branch implementation that uses the existing ImGuiImplDiligent class. I could rewrite the whole class and modify it how I like, but my implementation only adds a few functions to make the new features of the docking branch available in any1 Diligent application. A single call to m_pRenderer->RenderDrawData() is the final piece in the puzzle 😃.

I don't want to redundantly rewrite a whole class for one function call 🥲.

1eventually... currently only works with glfw + any backend, OpenGL, Vulkan DirectX etc... (not fully tested, but it getting there!)