search

DillonHammill / CytoExploreR

Interactive Cytometry Data Analysis
61 stars 13 forks source link

Images not rendered in Getting Started vignette #120

Closed mblue9 closed 3 years ago

mblue9 commented 3 years ago

Describe the bug Just to let you know none of the images in the Getting Started vignette have rendered. I built the pkgdown site for this repo locally and they all appear fine so maybe just a glitch with the build here?

To Reproduce See where images are supposed to be here https://dillonhammill.github.io/CytoExploreR/articles/CytoExploreR.html

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Additional context Add any other context about the problem here.

DillonHammill commented 3 years ago

Thanks for reporting this. pkgdown keeps setting the wrong paths to images in the docs folder. I will manually correct these today so that the images are displayed correctly.

DillonHammill commented 3 years ago

Done! The images should now appear on the website. I am not sure why pkgdown is getting all the image paths wrong - I will need to look into this at some point when I get some time.

mblue9 commented 3 years ago

Great! Looks good.

If you're building locally then pushing to Github maybe pkgdown is getting confused with the paths? You could use a Github Actions to auto-build e.g. here https://github.com/r-lib/actions/blob/master/examples/pkgdown.yaml