DillonHammill / CytoExploreR

Interactive Cytometry Data Analysis
60 stars 13 forks source link

Bug in custom plot layout #182

Open cleanylee opened 1 year ago

cleanylee commented 1 year ago

Describe the bug cyto_plot will generate multiple density distribution plots in custom plot laytout when density_stack is set to 0

To Reproduce

Load required packages

library(CytoExploreR) library(CytoExploreRData)

Load Activation GatingSet

gs <- cyto_load( system.file( "extdata/Activation-GatingSet", package = "CytoExploreRData" ) )

cyto_plot_custom(layout = c(2,2))

cyto_plot will generate one plots if the density_stack!=0 (Normal)

cyto_plot(gs[29:30], parent = "CD4 T Cells", alias = "CD69+ CD4 T Cells", channels = "CD69", density_stack = 0.5, title = "CD4 T Cells", label_text = NA)

If the density_stack==0, then the cyto_plot will generate mutiple plots (Bug)

cyto_plot(gs[29:30], parent = "CD4 T Cells", alias = "CD69+ CD4 T Cells", channels = "CD69", density_stack = 0, title = "CD4 T Cells", label_text = NA)

Expected behavior cyto_plot should generate only one plot when density_stack =0

Desktop (please complete the following information):

cleanylee commented 1 year ago

screenshot

Rplot02

cleanylee commented 1 year ago

There's no reply yet and the bug is still not fixed. Just a short follow-up, and being curious about the status of CytoExploreR. I remember Dillon mentioning about version 2.0 quite some time before. Is there still any plan for an update of CytoExploreR? I am using CytoExploreR everyday. I do love this package and hope it can survive forever.

DillonHammill commented 1 year ago

@cleanylee this looks like the expected behaviour to me. Each sample will be placed in its own panel with any sub populations overlaid even when density_stack = 0. density_stack doesn't control the number of layers per plot only the degree of overlap between them. You could try setting density_layers = 1 as well to force a single layer per plot. Loads of exciting things are coming, stay tuned... CytoExploreR is definitely here to stay!