DillonHammill / CytoExploreR

Interactive Cytometry Data Analysis
61 stars 13 forks source link

Experimental Details Editor doesn't like row elimination #49

Closed rwbaer closed 4 years ago

rwbaer commented 4 years ago

Briefly describe what you hope to achieve: Context: started with cyto_setup() procedure in preparation for a 2 channel spill correction scenario.

I was trying to use the experimental details editor to eliminate two files in a folder that were unnecessary for 2 channel spill correction. The editor provides the opportunity to right click and delete row. I did so. However, it seems unhappy if you do so and produces an error when you click save. See image below.

DetailsEditor

Outline the steps taken to attempt to reach this goal (paste code below):

Include any associated screenshots or images here:

DillonHammill commented 4 years ago

@rwbaer, this operation is not supported and probably never will be. It is too easy to accidentally remove files this way.

Use cyto_select() to pull out a subset of files and then pass them to the spillover functions.

If you don't want the files at all, use the exclude argument in cyto_setup().

rwbaer commented 4 years ago

I want to be sure you know ... Please know that I am by nature a prolific provider of feedback, and that I very much appreciate the beautiful software you have created here. Do not take my feedback as my disappointment with your efforts. To the contrary, I'm VERY blown away by them and very grateful that you have accomplished what you have. I'm also very grateful for your patience with me as I discover my way through putting your project into action. Hopefully, I'll catch on soon.

DillonHammill commented 4 years ago

@rwbaer, if you don't want the editors to open set markers = FALSE and/or details = FALSE in cyto_setup().

Column deletion is fine, but the name column should not be edited. I will put some restrictions on this so that this is more clear.

rwbaer commented 4 years ago

Ahhh.... '...more columns...' This aspect of cyto_setup() likely will be much more interesting/important when I finally get beyond spillover and gate setup and begin analyzing unknown samples with potentially more columns and fields that could need editing at setup time .
I'm still walking (limping); not running but each insight helps.