Enabling option for grid in the plot background

DillonHammill / CytoExploreR

Interactive Cytometry Data Analysis

61 stars 13 forks source link

Enabling option for grid in the plot background #83

Closed siveenks closed 3 years ago

siveenks commented 4 years ago

Hi, I have to perform lot of manual gating using CytoExploreR package and one of the drawbacks I found was the absence of a grid in the background of the plot.

When plotting with ggplot, we can get a grid in the background (example attached).

This help to decide the spot to click to generate a quadrant which will split the plot with a nice separation, or when creating a rectangle gates, help me to decide on which spots to click for generating the gate.

It would be really helpful if the cyto_plot_theme function has options for a background grid.

Thank you in advance.

Regards, Siveen

DillonHammill commented 4 years ago

@siveenks, I can certainly add support for this! I may have to change the old border_ arguments to start with panel_ instead and then add panel_grid_lines, panel_grid_line_type, panel_grid_line_width and panel_grid_line_col. I think it would useful if you could use this feature to display quantiles too - should be easy enough to do. I will work on this today so that it will be available in the next release.

siveenks commented 4 years ago

@DillonHammill, If the user have an option to enable quantiles to be shown as grid, that would be great. Please reply once you update the feature. Thank you..

DillonHammill commented 3 years ago

Thanks again for the suggestion @siveenks! I have added support for grid lines in version 2.0.0 of CytoExploreR (coming soon).

In fact, I like them so much that they are now turned on by default! Check out the the grid_ arguments for more details. I also added support for quantile lines by passing the probabilities directly through the grid argument (e.g. grid = c(0.05, 0.95)).

The new version will be out very soon, here is a sneak peak at the new plots: