DillonHammill / DataEditR

An Interactive R Package for Viewing, Entering Filtering and Editing Data
https://dillonhammill.github.io/DataEditR/
384 stars 40 forks source link

DataEdit as a function is not working #38

Closed luis-zapata-b closed 2 years ago

luis-zapata-b commented 2 years ago

Hello, When i try to save the result of the function, it does not work.

for example:

mtcars2 = DataEditR::data_edit(mtcars)

Will not save any changes in mtcars2.

Here is my session info: R version 4.1.2 (2021-11-01) Platform: x86_64-w64-mingw32/x64 (64-bit) Running under: Windows 10 x64 (build 18363)

Matrix products: default

locale: [1] LC_COLLATE=Spanish_Peru.1252 LC_CTYPE=Spanish_Peru.1252 LC_MONETARY=Spanish_Peru.1252 [4] LC_NUMERIC=C LC_TIME=Spanish_Peru.1252

attached base packages: [1] stats graphics grDevices utils datasets methods base

other attached packages: [1] forcats_0.5.1 stringr_1.4.0 dplyr_1.0.7 purrr_0.3.4 readr_2.1.1 tidyr_1.1.4
[7] tibble_3.1.6 ggplot2_3.3.5 tidyverse_1.3.1 shiny_1.7.1 editData_0.1.8

loaded via a namespace (and not attached): [1] httr_1.4.2 sass_0.4.0 jsonlite_1.7.2 modelr_0.1.8 bslib_0.3.1
[6] assertthat_0.2.1 cellranger_1.1.0 yaml_2.2.1 pillar_1.6.4 backports_1.4.0
[11] glue_1.5.1 digest_0.6.29 promises_1.2.0.1 rvest_1.0.2 colorspace_2.0-2
[16] htmltools_0.5.2 httpuv_1.6.3 pkgconfig_2.0.3 broom_0.7.10 haven_2.4.3
[21] xtable_1.8-4 scales_1.1.1 fontawesome_0.2.2 openxlsx_4.2.4 later_1.3.0
[26] rio_0.5.29 tzdb_0.2.0 generics_0.1.1 ellipsis_0.3.2 DT_0.20
[31] cachem_1.0.6 withr_2.4.3 cli_3.1.0 magrittr_2.0.1 crayon_1.4.2
[36] readxl_1.3.1 mime_0.12 fs_1.5.1 fansi_0.5.0 xml2_1.3.3
[41] foreign_0.8-81 tools_4.1.2 data.table_1.14.2 hms_1.1.1 lifecycle_1.0.1
[46] munsell_0.5.0 reprex_2.0.1 zip_2.2.0 compiler_4.1.2 jquerylib_0.1.4
[51] rlang_0.4.12 grid_4.1.2 rstudioapi_0.13 htmlwidgets_1.5.4 crosstalk_1.2.0
[56] miniUI_0.1.1.1 shinyWidgets_0.6.2 gtable_0.3.0 DBI_1.1.1 curl_4.3.2
[61] R6_2.5.1 lubridate_1.8.0 fastmap_1.1.0 utf8_1.2.2 stringi_1.7.5
[66] Rcpp_1.0.7 vctrs_0.3.8 dbplyr_2.1.1 tidyselect_1.1.1

DillonHammill commented 2 years ago

You have to use the sync button to merge changes to the master copy of the data.

moodymudskipper commented 2 years ago

This confused me too. I don't feel that "sync" describes the action best and it's error prone, could we maybe have an auto sync option ? Maybe renaming the "done" button to "quit" or "close" would also hint a bit more. Another option would be to have a "sync and close" button next to "done". I think that would have been enough to figure it out by myself.

Thanks for the great work.

Edit to whomever will need this: using hide = TRUE when editing data frames is perfect, it removes all extra buttons and no need to sync