search

DillonHammill / DataEditR

An Interactive R Package for Viewing, Entering Filtering and Editing Data
https://dillonhammill.github.io/DataEditR/
381 stars 40 forks source link

Does "contains" / "not contains" filters really works? #67

Open sbridel opened 6 months ago

sbridel commented 6 months ago

Hello.

For instance using iris$Species dataset, either Species CONTAINS / NOT CONTAINS "set" (setosa) doesn't return anything.

Am I doing something wrong ?

I checked the dataFilter() code but i cant see any problem but I am not familiar with this type of code and IDK how I could test something to work around this..

Cheeers

EDIT: I think it's the NOT CONTAIN which is slightly weird

sbridel commented 6 months ago

image

Only 5 setosa returned

image

sbridel commented 6 months ago

image it seems the not contains is broken

sbridel commented 6 months ago

EDIT =

if (logic == "contain") { return(ind)

NOT CONTAIN

            } else if (logic == "not contain") {
              return(seq_len(ncol(values$data))[-ind])
            }
          }

=> change to nrow?????

sbridel commented 6 months ago

Fixed on my fork : https://github.com/sbridel/DataEditR