search

DillonHammill / DataEditR

An Interactive R Package for Viewing, Entering Filtering and Editing Data
https://dillonhammill.github.io/DataEditR/
384 stars 40 forks source link

Adding Rows After Columns - FALSE #9

Closed DillonHammill closed 3 years ago

DillonHammill commented 3 years ago

It seems that there may be an issue when rows are added after columns have been added - the values in the added columns change to FALSE. I suspect that this is a rhandsontable issue that is caused by the new row setting an NA in the created columns where a handsontable column type has been set. This doesn't seem to happen all the time, for example in my docker images with rhandsontable 0.3.7 everything works as expected.

If this becomes an issue for users I will need to look into the rhandsontable code to figure out why this is happening.

DillonHammill commented 3 years ago

Turns out this is due to rhandsontable converting NA values to FALSE for checkbox columns. I have pushed a fix to my rhandsontable fork that bypasses this conversion when the column is contains only NA values.

devtools::install_github("DillonHammill/rhandsontable")