Dillonb / nmuidi

Deletes stuff, hopefully quickly
https://crates.io/crates/nmuidi
MIT License
229 stars 16 forks source link

Restructure to be closer to a library crate #3

Closed Riceman2000 closed 9 months ago

Riceman2000 commented 9 months ago

I like this project and I think some people would use it as a dependency for some other Rust projects so it would be great to make it usable as a library.

Once these changes are pushed I would love to see it published to crates.io (and maybe renamed no offense lol). Windows is a mess and anything to make development better on it is awesome.

I removed some of the benchmarking but I intentionally separated out some functions so they could be benchmarked by Cargo in the future. Here are some docs on this but it is a Nightly feature right now https://doc.rust-lang.org/cargo/commands/cargo-bench.html

Things still left to do if anyone is feeling up to it:

Reference #2 for more commentary.

Thanks!

Dillonb commented 9 months ago

Hi, thanks for the contribution! I'll look at this when I have some time and get it merged.

Riceman2000 commented 9 months ago

Awesome, thanks! Let me know if there are any changes you'd like to see

lowercasebtw commented 9 months ago

Any news?

brasky commented 9 months ago

Apologies for the delay! I've been looking through the changes (while learning Rust so please forgive me) and I think it looks great.

I ran a test against the same workload in my video (my fast build cache) and it ran well. image

image

And you even added tests, thanks a lot!