search

DimaKudosh / pydfs-lineup-optimizer

Daily Fantasy Sports lineup optimzer for all popular daily fantasy sports sites
MIT License
418 stars 157 forks source link

max / min ownership #303

Closed dachel12 closed 2 years ago

dachel12 commented 2 years ago

I am trying to use the optimizer.set_projected_ownership(max_projected_ownership=0.6) rule, but the optimizer is not following the rules I set for the max/min ownership. I have my projected_ownership in the salaries csv, so it should be pulling it in, but when I check the lineups that were generated, the ownerships are not within the range I specify.

Denwen12 commented 2 years ago

It should be named projected ownership without the underscore

On Fri, Sep 24, 2021, 11:06 PM dachel12 @.***> wrote:

I am trying to use the optimizer.set_projected_ownership(max_projected_ownership=0.6) rule, but the optimizer is not following the rules I set for the max/min ownership. I have my projected_ownership in the salaries csv, so it should be pulling it in, but when I check the lineups that were generated, the ownerships are not within the range I specify.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/DimaKudosh/pydfs-lineup-optimizer/issues/303, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANBWO7TJ5NFHFS46ODPJ3BTUDU4DVANCNFSM5EXDI2OQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

dachel12 commented 2 years ago

Wish that was it, but doesn't seem to have changed anything. The lineups run with no issue or error. Just the ownership projections are not taken into consideration

dachel12 commented 2 years ago

@Denwen12 Have you checked your lineups after the fact for ownership? I keep trying different things, but ultimately the final lineups I get are not following the rule. Also, looking through the code i am confused if I should be entering a max value for total ownership or averaging that value across the 9 players in an NFL lineup. Appreciate any help I can get

dachel12 commented 2 years ago

finally got it, but had to make several changes to various parts of the code