DimaKudosh / pydfs-lineup-optimizer

Daily Fantasy Sports lineup optimzer for all popular daily fantasy sports sites
MIT License
424 stars 157 forks source link

Fanduel is including Defense in single game this year. Still get player groups error however. #374

Open lightninglarry opened 2 years ago

lightninglarry commented 2 years ago

So i did include D into the lineup position inside of settings file. So thats not the issue. Playergroups is not working properly i feel.

Just toying around with things before the season, heres the code i used and error it produced.

kandd = PlayersGroup([optimizer.player_pool.get_player_by_name(Name) for Name in ('Matt Gay', 'Tyler Bass', 'Buffalo Bills', 'Los Angeles Rams' )], max_from_group=1) optimizer.add_players_group(kandd)

LineupOptimizerException: More than 1 player is found for: Matt Gay

lightninglarry commented 2 years ago

anyone have any advice on this matter? NFL Season is less than a week away.

LaptopHeaven commented 2 years ago
class FanDuelSingleGameWithDefFootballSettings(FanDuelSingleGameSettings):
    sport = Sport.FOOTBALL
    extra_rules = [FanduelSingleGameMaxQBRule]
    positions = [
        LineupPosition("MVP", ("MVP",)),
        LineupPosition("UTIL", ("QB", "WR", "RB", "TE", "K", "D")),
        LineupPosition("UTIL", ("QB", "WR", "RB", "TE", "K", "D")),
        LineupPosition("UTIL", ("QB", "WR", "RB", "TE", "K", "D")),
        LineupPosition("UTIL", ("QB", "WR", "RB", "TE", "K", "D")),
    ]

Then

optimizer = LineupOptimizer(FanDuelSingleGameWithDefFootballSettings)

lightninglarry commented 2 years ago
class FanDuelSingleGameWithDefFootballSettings(FanDuelSingleGameSettings):
    sport = Sport.FOOTBALL
    extra_rules = [FanduelSingleGameMaxQBRule]
    positions = [
        LineupPosition("MVP", ("MVP",)),
        LineupPosition("UTIL", ("QB", "WR", "RB", "TE", "K", "D")),
        LineupPosition("UTIL", ("QB", "WR", "RB", "TE", "K", "D")),
        LineupPosition("UTIL", ("QB", "WR", "RB", "TE", "K", "D")),
        LineupPosition("UTIL", ("QB", "WR", "RB", "TE", "K", "D")),
    ]

Then

optimizer = LineupOptimizer(FanDuelSingleGameWithDefFootballSettings)

where abouts do i put this line?

optimizer = LineupOptimizer(FanDuelSingleGameWithDefFootballSettings)

LaptopHeaven commented 2 years ago

Based on the sample, you probably have a line like this:

optimizer = get_optimizer(Site.YAHOO, Sport.BASKETBALL)

replace that line with

optimizer = LineupOptimizer(FanDuelSingleGameWithDefFootballSettings)

You also need to make sure to import LineupOptimizer

from pydfs_lineups_optimizer import LineupOptimizer

lightninglarry commented 2 years ago

@LaptopHeaven to piggyback on the question after the new class, does this group look right to you? Im wanting a max of 2 special team(k or d)

kandd = PlayersGroup([optimizer.player_pool.get_player_by_name(Name) for Name in ('Matt Gay', 'Tyler Bass', 'Buffalo Bills', 'Los Angeles Rams' )], max_from_group=2) optimizer.add_players_group(kandd)

because i still get the same error as before. Is this how you would syntax that group?

LaptopHeaven commented 2 years ago

without getting into the weeds, player groups and single games don't well; the player pool has two players with the same name, one for mvp and one for flex.

lightninglarry commented 2 years ago

im with ya. That is true on draftkings, but on Fanduel player is only listed once.

LaptopHeaven commented 2 years ago

while the player is only listed once in the input file, when the players are imported for a single game, pydfs creates a duplicate player for the MVP position, boosting the fppg value.

See https://github.com/DimaKudosh/pydfs-lineup-optimizer/blob/master/pydfs_lineup_optimizer/sites/fanduel/single_game/importer.py#L7

lightninglarry commented 2 years ago

ty for the help on this @LaptopHeaven

Denwen12 commented 2 years ago

A work around may be able to change deep cooy to shallow copy, I'll check into it later in the morning

Assignment statements in Python do not copy objects, they create bindings between a target and an object. For collections that are mutable or contain mutable items, a copy is sometimes needed so one can change one copy without changing the other. This module provides generic shallow and deep copy operations (explained below).

Interface summary:

copy.copy(x) Return a shallow copy of x.

copy.deepcopy(x[, memo]) Return a deep copy of x.

exception copy.Error Raised for module specific errors.

The difference between shallow and deep copying is only relevant for compound objects (objects that contain other objects, like lists or class instances):

A shallow copy constructs a new compound object and then (to the extent possible) inserts references into it to the objects found in the original.

A deep copy constructs a new compound object and then, recursively, inserts copies into it of the objects found in the original.

Two problems often exist with deep copy operations that don’t exist with shallow copy operations:

Recursive objects (compound objects that, directly or indirectly, contain a reference to themselves) may cause a recursive loop.

Because deep copy copies everything it may copy too much, such as data which is intended to be shared between copies.

The deepcopy() function avoids these problems by:

keeping a memo dictionary of objects already copied during the current copying pass; and

letting user-defined classes override the copying operation or the set of components copied.

This module does not copy types like module, method, stack trace, stack frame, file, socket, window, or any similar types. It does “copy” functions and classes (shallow and deeply), by returning the original object unchanged; this is compatible with the way these are treated by the pickle module.

Shallow copies of dictionaries can be made using dict.copy(), and of lists by assigning a slice of the entire list, for example, copied_list = original_list[:].

Classes can use the same interfaces to control copying that they use to control pickling. See the description of module pickle for information on these methods. In fact, the copy module uses the registered pickle functions from the copyreg module.

In order for a class to define its own copy implementation, it can define special methods copy() and deepcopy(). The former is called to implement the shallow copy operation; no additional arguments are passed. The latter is called to implement the deep copy operation; it is passed one argument, the memo dictionary. If the deepcopy() implementation needs to make a deep copy of a component, it should call the deepcopy() function with the component as first argument and the memo dictionary as second argument. The memo dictionary should be treated as an opaque object.