DimaKudosh / pydfs-lineup-optimizer

Daily Fantasy Sports lineup optimzer for all popular daily fantasy sports sites
MIT License
424 stars 157 forks source link

Issue with NHL Team Stacking #381

Closed PochynokB closed 2 years ago

PochynokB commented 2 years ago

Hi Dima,

I am trying to utilize features discussed in https://github.com/DimaKudosh/pydfs-lineup-optimizer/issues/66 . I have attempted to use your suggestion of :

''' optimizer.set_spacing_for_positions(['LW', 'RW', 'C'], 1) first parameter is a list of positions that will be used for constraint, second is spacing in your case it should be 1 because you want to select player with equal roster order And then you can use other rules optimizer.set_team_stacking([3, 3])' '''

I am getting the following errors: LineupOptimizerException: Incorrect positions. Choices are: frozenset({'LW', 'RW', 'C', 'G', 'D'})

AttributeError: 'LineupOptimizer' object has no attribute 'set_positions_for_same_team'

AttributeError: 'LineupOptimizer' object has no attribute 'set_team_stacking'

What am I missing?

Denwen12 commented 2 years ago

You can't set team stacks like that anymore

On Fri, Oct 7, 2022, 6:29 PM PochynokB @.***> wrote:

Hi Dima,

I am trying to utilize features discussed in #66 https://github.com/DimaKudosh/pydfs-lineup-optimizer/issues/66 . I have attempted to use your suggestion of :

optimizer.set_spacing_for_positions(['LW', 'RW', 'C'], 1) first parameter is a list of positions that will be used for constraint, second is spacing in your case it should be 1 because you want to select player with equal roster order And then you can use other rules

optimizer.set_team_stacking([3, 3])

I am getting the following errors: LineupOptimizerException: Incorrect positions. Choices are: frozenset({'LW', 'RW', 'C', 'G', 'D'})

AttributeError: 'LineupOptimizer' object has no attribute 'set_positions_for_same_team'

AttributeError: 'LineupOptimizer' object has no attribute 'set_team_stacking'

What am I missing?

— Reply to this email directly, view it on GitHub https://github.com/DimaKudosh/pydfs-lineup-optimizer/issues/381, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANBWO7XHHARSSDXSTWR5R4LWCCP4ZANCNFSM6AAAAAAQ76Y2Z4 . You are receiving this because you are subscribed to this thread.Message ID: @.***>

Denwen12 commented 2 years ago

optimizer.add_stack(TeamStack(3))

We use to be able to stack like the one you showed but that way was removed

On Fri, Oct 7, 2022, 6:36 PM joseph offen @.***> wrote:

You can't set team stacks like that anymore

On Fri, Oct 7, 2022, 6:29 PM PochynokB @.***> wrote:

Hi Dima,

I am trying to utilize features discussed in #66 https://github.com/DimaKudosh/pydfs-lineup-optimizer/issues/66 . I have attempted to use your suggestion of :

optimizer.set_spacing_for_positions(['LW', 'RW', 'C'], 1) first parameter is a list of positions that will be used for constraint, second is spacing in your case it should be 1 because you want to select player with equal roster order And then you can use other rules

optimizer.set_team_stacking([3, 3])

I am getting the following errors: LineupOptimizerException: Incorrect positions. Choices are: frozenset({'LW', 'RW', 'C', 'G', 'D'})

AttributeError: 'LineupOptimizer' object has no attribute 'set_positions_for_same_team'

AttributeError: 'LineupOptimizer' object has no attribute 'set_team_stacking'

What am I missing?

— Reply to this email directly, view it on GitHub https://github.com/DimaKudosh/pydfs-lineup-optimizer/issues/381, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANBWO7XHHARSSDXSTWR5R4LWCCP4ZANCNFSM6AAAAAAQ76Y2Z4 . You are receiving this because you are subscribed to this thread.Message ID: @.***>

PochynokB commented 2 years ago

So is there no longer a way to stack players from the same line?

Denwen12 commented 2 years ago

there is but not on a single line

On Fri, Oct 7, 2022 at 8:32 PM PochynokB @.***> wrote:

So is there no longer a way to stack players from the same line?

— Reply to this email directly, view it on GitHub https://github.com/DimaKudosh/pydfs-lineup-optimizer/issues/381#issuecomment-1272177751, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANBWO7SICCMD4HWEECLRFOLWCC6IDANCNFSM6AAAAAAQ76Y2Z4 . You are receiving this because you commented.Message ID: @.***>

--

ĵÖȘΈΦΗ

PochynokB commented 2 years ago

Can you explain how I might go about doing this? I can't find anything that is up to date.

PochynokB commented 2 years ago

I was able to get 1 team stack using this code:

optimizer.add_stack(TeamStack(3, for_positions=['C', 'LW', 'RW', 'D'], spacing=1))

However, when I add another TeamStack, it does not create a second team stack using the Roster Positions. It simply creates another regular TeamStack, which doesn't really work for NHL.

Denwen12 commented 2 years ago

We all have that same issue for sports

On Tue, Oct 11, 2022, 1:31 PM PochynokB @.***> wrote:

I was able to get 1 team stack using this code:

optimizer.add_stack(TeamStack(3, for_positions=['C', 'LW', 'RW', 'D'], spacing=1))

However, when I add another TeamStack, it does not create a second team stack using the Roster Positions. It simply creates another regular TeamStack, which doesn't really work for NHL.

— Reply to this email directly, view it on GitHub https://github.com/DimaKudosh/pydfs-lineup-optimizer/issues/381#issuecomment-1275043234, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANBWO7QGJ6LYJ6L3TUL5YDTWCWP6TANCNFSM6AAAAAAQ76Y2Z4 . You are receiving this because you commented.Message ID: @.***>

mbencho commented 2 years ago

If you include the spacing outside the TeamStack it does seem to work

optimizer.set_spacing_for_positions(['C', 'LW', 'RW', 'D'], 1)
optimizer.add_stack(TeamStack(3, for_positions=['C', 'LW', 'RW', 'D']))
optimizer.add_stack(TeamStack(3, for_positions=['C', 'LW', 'RW', 'D']))