Dimchikkk / velo

App for brainstorming & sharing ideas 🦀 Learning Project
Apache License 2.0
320 stars 27 forks source link

delete selected node #231

Closed ikorason closed 1 year ago

ikorason commented 1 year ago

when there is node selection, if pressed Del on keyboard, will remove that node

Dimchikkk commented 1 year ago

@irfanabliz does it interfer with removing selected text inside node?

ikorason commented 1 year ago

@StaffEngineer yes it does, it removes the text inside, should keep the text?

codecov[bot] commented 1 year ago

Codecov Report

Merging #231 (acf1d1e) into main (e4ac80a) will decrease coverage by 0.02%. Report is 1 commits behind head on main. The diff coverage is 0.00%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/StaffEngineer/velo/pull/231/graphs/tree.svg?width=650&height=150&src=pr&token=QGEKLM6ZDF&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)](https://app.codecov.io/gh/StaffEngineer/velo/pull/231?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) ```diff @@ Coverage Diff @@ ## main #231 +/- ## ========================================== - Coverage 12.78% 12.77% -0.02% ========================================== Files 59 59 Lines 7573 7580 +7 ========================================== Hits 968 968 - Misses 6605 6612 +7 ``` | [Files](https://app.codecov.io/gh/StaffEngineer/velo/pull/231?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [src/ui\_plugin/systems/keyboard.rs](https://app.codecov.io/gh/StaffEngineer/velo/pull/231?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL3VpX3BsdWdpbi9zeXN0ZW1zL2tleWJvYXJkLnJz) | `0.00% <0.00%> (ø)` | |
ikorason commented 1 year ago

basically it should be the same behaviour as the delete element button for selected node

Dimchikkk commented 1 year ago

@irfanabliz when text selected inside node delete should remove text rather than node (if it's current behaviour).

Dimchikkk commented 1 year ago

Let me test it tomorrow, not on PC atm.

ikorason commented 1 year ago

@irfanabliz when text selected inside node delete should remove text rather than node (if it's current behaviour).

so current behaviour is when selected text inside of the node (node will also be selected) and remove element button will remove the node as well as text inside

Dimchikkk commented 1 year ago

Yeah, it's all good... since selected text still can be deleted by backspace key.