Add support for storage controllers

[jeffstoner]

The Q release added support for multiple storage controllers. The current list of possible controllers is:

• VMware Paravirtual
• LSI Logic Parallel
• LSI Logic SAS

[tintoy]

Thanks for the reminder - I'll get onto this in a day or 2.

Do you mind if I ask what you're using the Go client for? Always good to understand consumer use-cases :)

[tintoy]

Hi @jeffstoner, this looks to be a bit trickier than I initially expected it to be. Turns out that the v2.5 APIs are less backward-compatible than versions.

For example:

• In v2.4, you can specify the SCSI unit Id for a disk, but in v2.5 you can only specify it if you specify the SCSI controller as well.
• The "deploy uncustomised server" API seems to be new in v2.5 and has moved several API fields around (e.g. networkDomainId is no longer under networkInfo).

I could introduce a second set of client methods (and their associated models) to avoid breaking existing consumers but it makes the client messy and harder to consume.

A bigger issue is the knock-on effects for upstream consumers such as the Terraform provider. If we go down that road then the provider will have to start maintaining separate code paths for a variety of resources (which makes the provider's behaviour harder to reason about and test).

CC: @kumarappanc @mingsheng36 @wninobla @johnamurray @alexbacchin

Your input would be appreciated, both regarding this design and the trade-offs it involves.

[tintoy]

CC: @manishkp @BenObermayer