search

DimensionDataResearch / terraform-provider-ddcloud

Terraform provider for Dimension Data cloud compute.
MIT License
16 stars 13 forks source link

Merge for new release #121

Closed samuelchong closed 5 years ago

samuelchong commented 5 years ago

create release for features added: datasource addresslist, resource address, bug fix

samuelchong commented 5 years ago

Travis failed. Any idea?

... ../../hashicorp/terraform/plans/planfile/writer.go:52:12: unknown field 'Modified' in struct literal of type zip.FileHeader The command "go get github.com/hashicorp/terraform" failed and exited with 2 during . Your build has been stopped.

tintoy commented 5 years ago

What version of go is being used for CI?

samuelchong commented 5 years ago

Travis passed now. Issue fixed using go 1.10. It was previously using 1.9

tintoy commented 5 years ago

Yeah, the folks at Hashicorp (and the go community in general) tend to always use latest everything 😉)

samuelchong commented 5 years ago

Thx @tintoy I know it's a big ask. I will attempt to carry on the good work you've started. Not many people here understand this project enough to do a code review for me. I am doing an upgrade of cloud control api and add more new features in the near future. You are always welcome to comment, feedback, review or criticise any code checkin, anytime :)

tintoy commented 5 years ago

No worries, it was one of the first open source projects I started - happy to help out where I can :)