search

DimensionDataResearch / terraform-provider-ddcloud

Terraform provider for Dimension Data cloud compute.
MIT License
16 stars 13 forks source link

Upgrade MCP Provider to be compatible with Terraform 0.12 #140

Closed nwright-nz closed 4 years ago

nwright-nz commented 4 years ago

Current provider is not compatible with Terraform 0.12 (see #132 ) - made changes to ensure the provider now functions with 0.12. As per terraform plugin best practices, I've also converted to go modules (not sure what the thoughts are on that - but its best practice and pretty painless) The actual changes to code are pretty light - updated all the schema and terraform references to use the new standalone sdk packages. The bulk of the work was updating tests that were a little out of date.

Also updated the readme, to reflect the new 0.12 syntax. Notes: the static route test does not complete - and all server tests fail with a non-empty plan (even though they do plan, apply and destroy successfully) Looks like this is because the backup url is a computed value - and will alway trigger a change at the moment. This most likely needs to be looked at outside of this PR. We do need a new release for go-dd-cloud-compute - I've tied the package to the latest commit in go.mod as the releases are way out of date, but would prefer to pin to a version, rather than commit id.

samuelchong commented 4 years ago

thanks @nwright-nz for the initiative. Your contribution is very much appreciated. I'll merge your changes into an upgrade branch, upon testing and verification, I'll merge it to dev and master.