search

DimensionDev / Maskbook-Talks

Where talks of Maskbook happen.
7 stars 1 forks source link

Discussion: Automatic wallet creation strategy #30

Open neruthes opened 4 years ago

neruthes commented 4 years ago

This matter is pretty tricky...

septs commented 4 years ago

I think the link between Persona and Wallet should be cancelled

neruthes commented 4 years ago

When to create?

A wallet should be created automatically in certain circumstances:

neruthes commented 4 years ago

Default name?

The initial 6 characters of the wallet address, e.g. 0x1234.

septs commented 4 years ago

Temporary solution: https://github.com/DimensionDev/Maskbook/pull/962

septs commented 4 years ago

I think we need to follow the on-demand principle.

neruthes commented 4 years ago

In a recent discussion, we agreed that the concept of Wallet here is like the concept of Address in shopping apps. A customer will need to create an address when he is about to place an order, and address-less users should be fine as long as they do not buy things.

With this in mind, we can largely avoid automatic creation, and use an opportunistic suggestion strategy. When a plugin is about to make an operation which requires the presence of a wallet, it should ask Maskbook to ask the user to add a wallet before proceeding. Related APIs include getWalletCount and askCreateWallet. For now, Red Packet and Gitcoin will require a wallet for certain operations, while native usages do not.